Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more examples on the Rust API #1785

Merged
merged 12 commits into from
Nov 4, 2020
Merged

Add more examples on the Rust API #1785

merged 12 commits into from
Nov 4, 2020

Conversation

jubianchi
Copy link
Contributor

@jubianchi jubianchi commented Oct 30, 2020 •
edited
Loading

Description

Review

  • Add a short description of the the change to the CHANGELOG.md file

@jubianchi jubianchi requested a review from Hywan as a code owner October 30, 2020 15:54
@Hywan Hywan added 🎉 enhancement New feature! 📚 documentation Do you like to read? labels Oct 30, 2020
@Hywan Hywan self-assigned this Oct 30, 2020
@jubianchi jubianchi marked this pull request as draft October 30, 2020 21:48
webmaster128
webmaster128 reviewed Nov 2, 2020
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Nov 2, 2020
View reviewed changes
examples/errors.rs Outdated Show resolved Hide resolved
@jubianchi jubianchi force-pushed the more-examples branch 3 times, most recently from 254cf40 to b991c7a Compare November 3, 2020 22:22
@jubianchi jubianchi marked this pull request as ready for review November 3, 2020 22:23
syrusakbary
syrusakbary reviewed Nov 3, 2020
View reviewed changes
examples/errors.rs Outdated
Comment on lines 1 to 2
//! A Wasm module can sometimes not work, it will produce errors in some
//! cases.
Copy link
Member

@syrusakbary syrusakbary Nov 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! A Wasm module can sometimes not work, it will produce errors in some
//! cases.
//! A Wasm module can sometimes be invalid or trigger traps, and in those case we will get
//! an error back from the API.

syrusakbary
syrusakbary reviewed Nov 3, 2020
View reviewed changes
examples/instance.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Nov 3, 2020
View reviewed changes
examples/instance.rs Outdated Show resolved Hide resolved
@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2020

Build succeeded:

@bors bors bot merged commit 692ca62 into master Nov 4, 2020
@bors bors bot deleted the more-examples branch November 4, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees

@Hywan Hywan

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jubianchi @syrusakbary @webmaster128 @Hywan